Catrope has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405377 )
Change subject: mediawiki.Uri: Don't double-escape fragments
......................................................................
mediawiki.Uri: Don't double-escape fragments
Fragments were ingested already-escaped, then escaped again
when serializing. To prevent double-escaping, decode fragments
when ingesting them.
Bug: T183710
Change-Id: I19fc889bb7bde446476203bf6d6352dce8298256
---
M resources/src/mediawiki/mediawiki.Uri.js
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/77/405377/1
diff --git a/resources/src/mediawiki/mediawiki.Uri.js
b/resources/src/mediawiki/mediawiki.Uri.js
index 450b415..c745b79 100644
--- a/resources/src/mediawiki/mediawiki.Uri.js
+++ b/resources/src/mediawiki/mediawiki.Uri.js
@@ -324,6 +324,9 @@
} );
}
uri.query = q;
+
+ // Decode uri.fragment, otherwise it gets
double-encoded when serializing
+ uri.fragment = Uri.decode( uri.fragment );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/405377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19fc889bb7bde446476203bf6d6352dce8298256
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
