Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405381 )

Change subject: revthank: Clarify confirmation message and change yes/no 
messages
......................................................................

revthank: Clarify confirmation message and change yes/no messages

Bug: T159302
Change-Id: I49ac7d644f207fe76a49efd650b727e33049b3af
---
M extension.json
M i18n/en.json
M modules/ext.thanks.revthank.js
3 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks 
refs/changes/81/405381/1

diff --git a/extension.json b/extension.json
index 5e30b49..89dbae3 100644
--- a/extension.json
+++ b/extension.json
@@ -76,7 +76,7 @@
                                "thanks-confirmation2",
                                "thanks-thank-tooltip-no",
                                "thanks-thank-tooltip-yes",
-                               "ok",
+                               "thanks-button-thank",
                                "cancel"
                        ],
                        "dependencies": [
diff --git a/i18n/en.json b/i18n/en.json
index 80d8501..50464f4 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -22,7 +22,7 @@
        "thanks-thank-tooltip": "{{GENDER:$1|Send}} a thank you notification to 
this {{GENDER:$2|user}}",
        "thanks-thank-tooltip-no": "{{GENDER:$1|Cancel}} the thank you 
notification",
        "thanks-thank-tooltip-yes": "{{GENDER:$1|Send}} the thank you 
notification",
-       "thanks-confirmation2": "{{GENDER:$1|Send}} public thanks for this 
edit?",
+       "thanks-confirmation2": "All thanks are public. {{GENDER:$1|Send}} 
thanks?",
        "thanks-thanked-notice": "{{GENDER:$3|You}} thanked $1 for 
{{GENDER:$2|his|her|their}} edit.",
        "thanks": "Send thanks",
        "thanks-submit": "Send thanks",
diff --git a/modules/ext.thanks.revthank.js b/modules/ext.thanks.revthank.js
index e577d28..cf4e5c3 100644
--- a/modules/ext.thanks.revthank.js
+++ b/modules/ext.thanks.revthank.js
@@ -64,7 +64,9 @@
                        $thankLink.confirmable( {
                                i18n: {
                                        confirm: mw.msg( 
'thanks-confirmation2', mw.user ),
+                                       no: mw.msg( 'cancel' ),
                                        noTitle: mw.msg( 
'thanks-thank-tooltip-no', mw.user ),
+                                       yes: mw.msg( 'thanks-button-thank', 
mw.user, $thankLink.data( 'recipient-gender' ) ),
                                        yesTitle: mw.msg( 
'thanks-thank-tooltip-yes', mw.user )
                                },
                                handler: function ( e ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/405381
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49ac7d644f207fe76a49efd650b727e33049b3af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to