Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405405 )
Change subject: [DNM] jenkins testing
......................................................................
[DNM] jenkins testing
Change-Id: Id7992f3a01da92e9e8772dfbca118df8b354251f
---
M includes/shell/FirejailCommand.php
M tests/phpunit/MediaWikiCoversValidator.php
M tests/phpunit/includes/EditPageTest.php
3 files changed, 3 insertions(+), 35 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/05/405405/1
diff --git a/includes/shell/FirejailCommand.php
b/includes/shell/FirejailCommand.php
index a71b376..ae7a8ba 100644
--- a/includes/shell/FirejailCommand.php
+++ b/includes/shell/FirejailCommand.php
@@ -142,7 +142,7 @@
}
if ( $this->hasRestriction( Shell::PRIVATE_DEV ) ) {
- $cmd[] = '--private-dev';
+ //$cmd[] = '--private-dev';
}
if ( $this->hasRestriction( Shell::NO_NETWORK ) ) {
diff --git a/tests/phpunit/MediaWikiCoversValidator.php
b/tests/phpunit/MediaWikiCoversValidator.php
index a79a139..d3719a4 100644
--- a/tests/phpunit/MediaWikiCoversValidator.php
+++ b/tests/phpunit/MediaWikiCoversValidator.php
@@ -30,6 +30,8 @@
/**
* Test that all methods in this class that begin
* with "test" have valid covers tags.
+ *
+ * @coversNothing
*/
public function testValidCovers() {
$methods = get_class_methods( $this );
diff --git a/tests/phpunit/includes/EditPageTest.php
b/tests/phpunit/includes/EditPageTest.php
index 65c5d65..e04fda7 100644
--- a/tests/phpunit/includes/EditPageTest.php
+++ b/tests/phpunit/includes/EditPageTest.php
@@ -41,40 +41,6 @@
parent::tearDown();
}
- /**
- * @dataProvider provideExtractSectionTitle
- * @covers EditPage::extractSectionTitle
- */
- public function testExtractSectionTitle( $section, $title ) {
- $extracted = EditPage::extractSectionTitle( $section );
- $this->assertEquals( $title, $extracted );
- }
-
- public static function provideExtractSectionTitle() {
- return [
- [
- "== Test ==\n\nJust a test section.",
- "Test"
- ],
- [
- "An initial section, no header.",
- false
- ],
- [
- "An initial section with a fake heder
(T34617)\n\n== Test == ??\nwtf",
- false
- ],
- [
- "== Section ==\nfollowed by a fake ==
Non-section == ??\nnoooo",
- "Section"
- ],
- [
- "== Section== \t\r\n followed by whitespace
(T37051)",
- 'Section',
- ],
- ];
- }
-
protected function forceRevisionDate( WikiPage $page, $timestamp ) {
$dbw = wfGetDB( DB_MASTER );
--
To view, visit https://gerrit.wikimedia.org/r/405405
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7992f3a01da92e9e8772dfbca118df8b354251f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
