jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403748 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: Ia6381370eae10170f45764a9a347020d994f2719
---
M .phpcs.xml
M XAnalytics.class.php
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, approved
diff --git a/.phpcs.xml b/.phpcs.xml
index e853884..f189ea1 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,13 +2,10 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
- <exclude-pattern>node_modules</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
diff --git a/XAnalytics.class.php b/XAnalytics.class.php
index 6bc939e..f0e2bed 100644
--- a/XAnalytics.class.php
+++ b/XAnalytics.class.php
@@ -8,6 +8,7 @@
* @var bool
*/
private static $addedHeader = false;
+
/**
* Set X-Analytics header before the output buffer is flushed.
*
@@ -22,6 +23,8 @@
* by calling XAnalytics;:addItem().
*
* @see https://wikitech.wikimedia.org/wiki/X-Analytics
+ * @param OutputPage &$out
+ * @param Skin &$skin
*/
public static function onBeforePageDisplay( OutputPage &$out, Skin
&$skin ) {
self::generateHeader( $out );
--
To view, visit https://gerrit.wikimedia.org/r/403748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6381370eae10170f45764a9a347020d994f2719
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/XAnalytics
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
