jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403708 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I7e32340cca77ec4989a9be6d7ac93b1f1aeb6587
---
M .phpcs.xml
M includes/SpecialOverrideThrottle.php
M includes/ThrottleOverrideHooks.php
3 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
EddieGP: Looks good to me, but someone else must approve
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, approved
diff --git a/.phpcs.xml b/.phpcs.xml
index d47a43e..50e2c6c 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,9 +2,6 @@
<ruleset name="MediaWiki">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="Squiz.Scope.MethodScope.Missing" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
diff --git a/includes/SpecialOverrideThrottle.php
b/includes/SpecialOverrideThrottle.php
index 70f96d7..77414e7 100644
--- a/includes/SpecialOverrideThrottle.php
+++ b/includes/SpecialOverrideThrottle.php
@@ -242,7 +242,7 @@
* @param string $target IP address or range
* @param string|bool $expiry
* @param string $types
- * $param array $parsedRange
+ * @param array $parsedRange
* @return array
*/
public static function validateFields( $target, $expiry, $types,
$parsedRange ) {
diff --git a/includes/ThrottleOverrideHooks.php
b/includes/ThrottleOverrideHooks.php
index 43bb38b..16083e0 100644
--- a/includes/ThrottleOverrideHooks.php
+++ b/includes/ThrottleOverrideHooks.php
@@ -37,9 +37,9 @@
/**
* @throws InvalidArgumentException If $action is invalid
*
- * @param User $user
+ * @param User &$user
* @param string $action
- * @param $result
+ * @param bool &$result
* @param null|string $ip
*
* @return bool
--
To view, visit https://gerrit.wikimedia.org/r/403708
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e32340cca77ec4989a9be6d7ac93b1f1aeb6587
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ThrottleOverride
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: EddieGP <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
