jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405324 )
Change subject: Config stylelint to lint css files
......................................................................
Config stylelint to lint css files
Already part of package.json
Expected newline after ","
Change-Id: I98c67ea480bf5613a459caf4ae2211c89beb27ef
---
A .stylelintrc.json
M Gruntfile.js
M modules/ext.acw.landingPage.css
3 files changed, 23 insertions(+), 4 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.stylelintrc.json b/.stylelintrc.json
new file mode 100644
index 0000000..b341a4e
--- /dev/null
+++ b/.stylelintrc.json
@@ -0,0 +1,7 @@
+{
+ "extends": "stylelint-config-wikimedia",
+ "rules": {
+ "selector-no-id": null,
+ "declaration-no-important": null
+ }
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index 7cef05d..dff19be 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -6,6 +6,7 @@
grunt.loadNpmTasks( 'grunt-contrib-watch' );
grunt.loadNpmTasks( 'grunt-eslint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-stylelint' );
grunt.initConfig( {
eslint: {
@@ -20,8 +21,9 @@
banana: conf.MessagesDirs,
watch: {
files: [
- '.eslintrc.json',
- '<%= eslint.all %>'
+ '.{stylelintrc,eslintrc}.json',
+ '<%= eslint.all %>',
+ '<%= stylelint.all %>'
],
tasks: 'test'
},
@@ -32,10 +34,18 @@
'!vendor/**',
'!docs/**'
]
+ },
+ stylelint: {
+ all: [
+ '**/*.css',
+ '!node_modules/**',
+ '!vendor/**',
+ '!docs/**'
+ ]
}
} );
- grunt.registerTask( 'lint', [ 'eslint', 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'lint', [ 'eslint', 'jsonlint', 'banana',
'stylelint' ] );
grunt.registerTask( 'test', 'lint' );
grunt.registerTask( 'default', 'test' );
};
diff --git a/modules/ext.acw.landingPage.css b/modules/ext.acw.landingPage.css
index 1c0eb12..ae646e0 100644
--- a/modules/ext.acw.landingPage.css
+++ b/modules/ext.acw.landingPage.css
@@ -1,6 +1,8 @@
/*
* Hide unneeded page elements.
*/
-#firstHeading, #siteSub, #catlinks {
+#firstHeading,
+#siteSub,
+#catlinks {
display: none !important;
}
--
To view, visit https://gerrit.wikimedia.org/r/405324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98c67ea480bf5613a459caf4ae2211c89beb27ef
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
