Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405570 )
Change subject: Use preg_quote on test class names for safety
......................................................................
Use preg_quote on test class names for safety
Just in case there's something weird in the filename.
Change-Id: Ibadbafa117020a2b91450c3828daedc907ccb959
---
M src/CheckCommand.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/tools/phpunit-patch-coverage
refs/changes/70/405570/1
diff --git a/src/CheckCommand.php b/src/CheckCommand.php
index a0d8305..1b7bb66 100644
--- a/src/CheckCommand.php
+++ b/src/CheckCommand.php
@@ -76,7 +76,9 @@
foreach ( $tests as $test ) {
$base = basename( $test );
// Strip extension
- $filter[] = substr( $base, 0, strlen( $base ) - 4 );
+ $filter[] = preg_quote(
+ substr( $base, 0, strlen( $base ) - 4 )
+ );
}
return '\'/' . implode( '|', $filter ) . '/\'';
--
To view, visit https://gerrit.wikimedia.org/r/405570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibadbafa117020a2b91450c3828daedc907ccb959
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/phpunit-patch-coverage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
