Andrew Bogott has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405671 )
Change subject: role::client::labs: remove hiera defaults that rely on ::global vars ...................................................................... role::client::labs: remove hiera defaults that rely on ::global vars I don't think these can be getting set anyplace, so make the default [] which is the behavior we're getting from unset globals anyway. Change-Id: I435effd2604ace9f6180975fe0de754af6c086ca --- M modules/ldap/manifests/role/client/labs.pp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/71/405671/1 diff --git a/modules/ldap/manifests/role/client/labs.pp b/modules/ldap/manifests/role/client/labs.pp index 664bcdc..77a387c 100644 --- a/modules/ldap/manifests/role/client/labs.pp +++ b/modules/ldap/manifests/role/client/labs.pp @@ -1,7 +1,7 @@ class ldap::role::client::labs( $ldapincludes=['openldap', 'utils'], - $restricted_to = $::restricted_to, - $restricted_from = $::restricted_from, + $restricted_to = [], + $restricted_from = [], ) { include ::ldap::role::config::labs -- To view, visit https://gerrit.wikimedia.org/r/405671 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I435effd2604ace9f6180975fe0de754af6c086ca Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Andrew Bogott <abog...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits