jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405254 )
Change subject: Fix member variable visbility and doc
......................................................................
Fix member variable visbility and doc
Change-Id: I22d16b05d24c615f0c792063e33433d50a34ad8a
---
M .phpcs.xml
M tests/phpunit/ApiFlowThankIntegrationTest.php
2 files changed, 15 insertions(+), 9 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index f55eb30..3f9d0cb 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -6,7 +6,6 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
- <exclude name="Squiz.Scope.MemberVarScope.Missing" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
diff --git a/tests/phpunit/ApiFlowThankIntegrationTest.php
b/tests/phpunit/ApiFlowThankIntegrationTest.php
index 8bfcfee..60a79af 100644
--- a/tests/phpunit/ApiFlowThankIntegrationTest.php
+++ b/tests/phpunit/ApiFlowThankIntegrationTest.php
@@ -18,14 +18,21 @@
* @author Benjamin Chen
*/
class ApiFlowThankTest extends ApiTestCase {
- /**
- * @var PostRevision
- */
- public $topic,
- $meUser,
- $otherUser,
- $postByOtherUser,
- $postByMe;
+
+ /** @var PostRevision */
+ public $topic;
+
+ /** @var User */
+ public $meUser;
+
+ /** @var User */
+ public $otherUser;
+
+ /** @var PostRevision */
+ public $postByOtherUser;
+
+ /** @var PostRevision */
+ public $postByMe;
public function setUp() {
parent::setUp();
--
To view, visit https://gerrit.wikimedia.org/r/405254
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22d16b05d24c615f0c792063e33433d50a34ad8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Samwilson <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
