Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/58245


Change subject: (bug 47023) Add array type check before being used in foreach 
loop
......................................................................

(bug 47023) Add array type check before being used in foreach loop

Change-Id: I28e7f1a52b337ee0a4b012ad31e8054c8f6798ed
---
M includes/DiscussionParser.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/45/58245/1

diff --git a/includes/DiscussionParser.php b/includes/DiscussionParser.php
index b56fff4..ef37281 100644
--- a/includes/DiscussionParser.php
+++ b/includes/DiscussionParser.php
@@ -103,6 +103,10 @@
 
                $output = self::parseNonEditWikitext( $content, new Article( 
$title ) );
                $links = $output->getLinks();
+
+               if ( !isset( $links[NS_USER] ) || !is_array( $links[NS_USER] ) 
) {
+                       return;
+               }
                $mentionedUsers = array();
                $count = 0;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/58245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28e7f1a52b337ee0a4b012ad31e8054c8f6798ed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to