jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405037 )
Change subject: Limit line length to 80 characters ...................................................................... Limit line length to 80 characters Enforce it with eslint. Ignore: * Comment lines with eslint disable directives * QUnit test lines as they contain long subjects (QUnit.* (only, test, module, skip, etc) * Strings, since long strings are used extensively in tests * Ignore template literals for similar reasons * Regex literals as they may be too long, but can't be easily split in several lines * Long urls See bug for more general proposal for eslint-wikimedia-config. Bug: T185295 Change-Id: I3aacaf46e61a4d96547c513073e179ef997deb09 --- M .eslintrc.json M resources/dist/index.js.json M src/actions.js M src/constants.js M src/formatter.js M src/gateway/index.js M src/gateway/rest.js M src/getUserBucket.js M src/index.js M src/instrumentation/eventLogging.js M src/preview/model.js M src/reducers/eventLogging.js M src/title.js M src/ui/renderer.js M src/ui/settingsDialog.js M src/userSettings.js M tests/node-qunit/actions.test.js M tests/node-qunit/changeListeners/render.test.js M tests/node-qunit/changeListeners/settings.test.js M tests/node-qunit/counts.test.js M tests/node-qunit/gateway/index.test.js M tests/node-qunit/gateway/mediawiki.test.js M tests/node-qunit/gateway/rest.test.js M tests/node-qunit/getUserBucket.test.js M tests/node-qunit/instrumentation/eventLogging.test.js M tests/node-qunit/integration.test.js M tests/node-qunit/preview/model.test.js M tests/node-qunit/reducers/eventLogging.test.js M tests/node-qunit/title.test.js M tests/node-qunit/ui/renderer.test.js M tests/node-qunit/userSettings.test.js 31 files changed, 395 insertions(+), 213 deletions(-) Approvals: Niedzielski: Looks good to me, but someone else must approve jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/405037 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aacaf46e61a4d96547c513073e179ef997deb09 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
