Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405816 )
Change subject: Don't hide notification popup when scrolling
......................................................................
Don't hide notification popup when scrolling
hideWhenOutOfView is for preventing popups from appearing
outside their container, but in this case the container
is the document, so it is already clipped.
Bug: T178384
Change-Id: Ie0cd83849446cf74b61e708f0a1fa79f2384a94a
---
M modules/ui/mw.echo.ui.NotificationBadgeWidget.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/16/405816/1
diff --git a/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
b/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
index ce7956d..de02adc 100644
--- a/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
+++ b/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
@@ -130,6 +130,7 @@
$content: this.notificationsWidget.$element,
$footer: $footer,
width: config.popupWidth || 500,
+ hideWhenOutOfView: false,
autoFlip: false,
autoClose: true,
containerPadding: 20,
--
To view, visit https://gerrit.wikimedia.org/r/405816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0cd83849446cf74b61e708f0a1fa79f2384a94a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
