Muehlenhoff has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/405859 )

Change subject: Add ops-staff-group to exception list for ops membership 
consistency check
......................................................................


Add ops-staff-group to exception list for ops membership consistency check

Change-Id: I946f6f8122f67ebd0195f8a37061dbc7bd29a0fb
---
M modules/openldap/files/cross-validate-accounts.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Muehlenhoff: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/openldap/files/cross-validate-accounts.py 
b/modules/openldap/files/cross-validate-accounts.py
index 6d38b2f..0e938d1 100644
--- a/modules/openldap/files/cross-validate-accounts.py
+++ b/modules/openldap/files/cross-validate-accounts.py
@@ -240,13 +240,14 @@
                 #    cluster-wide root permissions, so might be used in 
addition to ops privs
                 # researchers enables mysql access in addition to cluster-wide 
root permissions,
                 #    so might be used in addition to ops privs
+                # ops-staff-group is auto-generated from the ops membership
                 # statistics-privatedata-users enables mysql access as well
                 # deploy-phabricator concerns handling of keyholder for 
deployment
                 # analytics-search-users concerns user creation in HDFS
                 # contint-docker is about being able to issue docker commands
                 # directly and execute scripts issuing docker commands
                 groups.difference_update(['analytics-privatedata-users', 
'gitpuppet', 'ops',
-                                          'researchers',
+                                          'researchers', 'ops-staff-group',
                                           'statistics-privatedata-users',
                                           'contint-docker',
                                           'deploy-phabricator', 
'analytics-search-users'])

-- 
To view, visit https://gerrit.wikimedia.org/r/405859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I946f6f8122f67ebd0195f8a37061dbc7bd29a0fb
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Muehlenhoff <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to