Thiemo Kreuz (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405875 )
Change subject: Remove not needed Statements from Multi/SingleValueChecker tests
......................................................................
Remove not needed Statements from Multi/SingleValueChecker tests
Bug: T175566
Change-Id: I6802e7ecdd2638c4f0112798a6eafb57c3a5c873
---
M tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
2 files changed, 2 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/75/405875/1
diff --git a/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
b/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
index cfdd52d..d80e567 100644
--- a/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
@@ -83,9 +83,7 @@
$statement = NewStatement::someValueFor( 'P10' )->build();
$statement->getQualifiers()->addSnak( $qualifier1 );
$statement->getQualifiers()->addSnak( $qualifier2 );
- $item = NewItem::withStatement( $statement )
- ->andStatement( NewStatement::someValueFor( 'P1' ) )
- ->build();
+ $item = NewItem::withStatement( $statement )->build();
$context = new QualifierContext( $item, $statement, $qualifier1
);
$checkResult = $this->checker->checkConstraint( $context,
$this->constraint );
diff --git a/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
b/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
index 7d4404f..5ae7df5 100644
--- a/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
+++ b/tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
@@ -83,9 +83,7 @@
$statement = NewStatement::someValueFor( 'P10' )->build();
$statement->getQualifiers()->addSnak( $qualifier1 );
$statement->getQualifiers()->addSnak( $qualifier2 );
- $item = NewItem::withStatement( $statement )
- ->andStatement( NewStatement::someValueFor( 'P1' ) )
- ->build();
+ $item = NewItem::withStatement( $statement )->build();
$context = new QualifierContext( $item, $statement, $qualifier1
);
$checkResult = $this->checker->checkConstraint( $context,
$this->constraint );
--
To view, visit https://gerrit.wikimedia.org/r/405875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6802e7ecdd2638c4f0112798a6eafb57c3a5c873
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
