jenkins-bot has submitted this change and it was merged.
Change subject: Be resilient against an unset hrefPrefix in MWCategoryMetaItem
......................................................................
Be resilient against an unset hrefPrefix in MWCategoryMetaItem
(or any unset attribute for that matter)
Change-Id: I59364354c64fbce016090e17aa9683ec0a0fea9b
---
M modules/ve/dm/metaitems/ve.dm.MWCategoryMetaItem.js
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/dm/metaitems/ve.dm.MWCategoryMetaItem.js
b/modules/ve/dm/metaitems/ve.dm.MWCategoryMetaItem.js
index 072d2a9..dc276fe 100644
--- a/modules/ve/dm/metaitems/ve.dm.MWCategoryMetaItem.js
+++ b/modules/ve/dm/metaitems/ve.dm.MWCategoryMetaItem.js
@@ -51,11 +51,11 @@
ve.dm.MWCategoryMetaItem.static.toDomElements = function ( dataElement ) {
var href,
domElement = document.createElement( 'link' ),
- hrefPrefix = dataElement.attributes.hrefPrefix,
- category = dataElement.attributes.category,
- sortkey = dataElement.attributes.sortkey,
- origCategory = dataElement.attributes.origCategory,
- origSortkey = dataElement.attributes.origSortkey,
+ hrefPrefix = dataElement.attributes.hrefPrefix || '',
+ category = dataElement.attributes.category || '',
+ sortkey = dataElement.attributes.sortkey || '',
+ origCategory = dataElement.attributes.origCategory || '',
+ origSortkey = dataElement.attributes.origSortkey || '',
normalizedOrigCategory = decodeURIComponent( origCategory
).replace( /_/g, ' ' ),
normalizedOrigSortkey = decodeURIComponent( origSortkey );
if ( normalizedOrigSortkey === sortkey ) {
--
To view, visit https://gerrit.wikimedia.org/r/58270
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59364354c64fbce016090e17aa9683ec0a0fea9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
