Krinkle has submitted this change and it was merged.
Change subject: Don't run check pipeline if the user is allowd test pipeline
......................................................................
Don't run check pipeline if the user is allowd test pipeline
This is the ugly way to test it, but it's better than nothing.
Constantly having jenkins-bot run the tests twice and the
overhead is just too much:
- Wasted processing time for Jenkins and Zuul running lots of
jobs twice for no reason, occupying the queue.
- Double the notifications from Jenkins
- Double the comments from jenkins-bot
- Race condition bug where V+1 (check: success) can sometimes
overrides V-2 (test: failure).
Bug: 43391
Change-Id: Ic9a3411406fafdb0de19ed20d7e717b20280fd7d
---
M layout.yaml
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/layout.yaml b/layout.yaml
index 1390c45..1e9200c 100644
--- a/layout.yaml
+++ b/layout.yaml
@@ -31,11 +31,12 @@
manager: IndependentPipelineManager
trigger:
- event: patchset-created
+ # Don't run the check pipeline if the user is allowd to run the test
pipeline (bug 43391).
+ # TODO: Figure out a way to turn this into a list instead of a
single-line regex.
+ # TODO: Figure out a way to not have to repeat this from pipeline
'test'.
+ # This email_filter and the one for 'test' can be removed once we have
fixed bug 45499.
email_filter:
- # VisualEditor team:
- # Don't trigger the 'check' pipeline in addition to the 'test'
pipeline
- # TODO: Figure out a way to not have to repeat this reversed here
from 'test'
- -
^(?!(roan\.kattouw@gmail\.com|krinklemail@gmail\.com|trevorparscal@gmail\.com|inez@wikia-inc\.com|orbit@framezero\.com)).*$
+ -
^(?!(.*?@wikimedia\.org|.*?@wikimedia\.de|anomie\.wikipedia@gmail\.com|amir\.aharoni@mail\.huji\.ac\.il|hashar@free\.fr|jeroendedauw@gmail\.com|maxsem\.wiki@gmail\.com|mtraceur@member\.fsf\.org|niklas\.laxstrom@gmail\.com|s\.mazeland@xs4all\.nl|stefan\.petrea@gmail\.com|stefan@garage-coding\.com|roan\.kattouw@gmail\.com|krinklemail@gmail\.com|trevorparscal@gmail\.com|inez@wikia-inc\.com|orbit@framezero\.com|aude\.wiki@gmail\.com|bawolff\+wn@gmail\.com|bryan\.tongminh@gmail\.com|dereckson@espace-win\.org|hartman\.wiki@gmail\.com|hoo@online\.de|ialex\.wiki@gmail\.com|jamesin\.hongkong\.1@gmail\.com|krenair@gmail\.com|liangent@gmail\.com|mah@everybody\.org|matma\.rex@gmail\.com|raimond\.spekking@gmail\.com|robinp\.1273@gmail\.com|tim@tim-landscheidt\.de|umherirrender_de\.wp@web\.de|yuriastrakhan@gmail\.com|yaron57@gmail\.com|markus@semantic-mediawiki\.org|s7eph4n@gmail\.org)).*$
- event: comment-added
comment_filter: (?im)^Patch Set \d+:\n\n\s*recheck\.?\s*$
success:
@@ -65,8 +66,9 @@
trigger:
- event: patchset-created
- # Make sure to use non greedy selectors (.*?) and to escape
- # dots: \.
+ # BEWARE:
+ # - Make sure to use non greedy selectors (.*?) and to escape dots: \.
+ # - Also update the email_filter of the 'check' pipeline.
email_filter:
- .*?@wikimedia\.org$
--
To view, visit https://gerrit.wikimedia.org/r/58273
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9a3411406fafdb0de19ed20d7e717b20280fd7d
Gerrit-PatchSet: 2
Gerrit-Project: integration/zuul-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
