Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58292
Change subject: Initialize empty $discardChangesButton
......................................................................
Initialize empty $discardChangesButton
Bug: 47036
Change-Id: I16c86bdf921cbb8da97d1c623d99a4dc8d1cceb0
---
M resources/js/ext.translate.editor.js
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/92/58292/1
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index 5b6bd98..a239fc3 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -263,7 +263,7 @@
$controlButtonBlock,
$editingButtonBlock,
$pasteOriginalButton,
- $discardChangesButton,
+ $discardChangesButton = $( [] ),
$saveButton,
$requestRight,
$skipButton,
@@ -455,9 +455,7 @@
$pasteOriginalButton.addClass(
'hide' );
} );
- if ( originalTranslation === null ) {
- $discardChangesButton = $( [] );
- } else {
+ if ( originalTranslation !== null ) {
$discardChangesButton = $( '<button>' )
.addClass(
'tux-editor-discard-changes-button hide' ) // Initially hidden
.text( mw.msg(
'tux-editor-discard-changes-button-label' ) )
--
To view, visit https://gerrit.wikimedia.org/r/58292
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16c86bdf921cbb8da97d1c623d99a4dc8d1cceb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
