jenkins-bot has submitted this change and it was merged.
Change subject: Add some implicit class variables
......................................................................
Add some implicit class variables
Also removed an unused and undefined class variable.
Change-Id: Ic94b03cd8aafca33ac3d82425dde195fb10c2000
---
M specials/SpecialSearchTranslations.php
M specials/SpecialTranslate.php
M tests/ffs/GettextFFSTest.php
M ttmserver/SolrTTMServer.php
4 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/specials/SpecialSearchTranslations.php
b/specials/SpecialSearchTranslations.php
index 15418f5..be376e7 100644
--- a/specials/SpecialSearchTranslations.php
+++ b/specials/SpecialSearchTranslations.php
@@ -14,6 +14,9 @@
* @ingroup SpecialPage TranslateSpecialPage
*/
class SpecialSearchTranslations extends SpecialPage {
+ /** @var FormOptions */
+ protected $opts;
+
/**
* Placeholders used for highlighting. Solr can mark the beginning and
* end but we need to run htmlspecialchars on the result first and then
diff --git a/specials/SpecialTranslate.php b/specials/SpecialTranslate.php
index cc489fd..d6ceae6 100644
--- a/specials/SpecialTranslate.php
+++ b/specials/SpecialTranslate.php
@@ -148,7 +148,6 @@
$priorityForce = TranslateMetadata::get(
$groupId, 'priorityforce' );
if ( $priorityForce === 'on' ) {
// Hide table
- $this->paging['count'] = 0;
$priorityMessageClass = 'errorbox';
$priorityMessageKey =
'tpt-discouraged-language-force';
} else {
diff --git a/tests/ffs/GettextFFSTest.php b/tests/ffs/GettextFFSTest.php
index d389b31..43521d2 100644
--- a/tests/ffs/GettextFFSTest.php
+++ b/tests/ffs/GettextFFSTest.php
@@ -12,6 +12,7 @@
* @see GettextFFS
*/
class GettextFFSTest extends MediaWikiTestCase {
+ protected $groupConfiguration;
public function setUp() {
parent::setUp();
diff --git a/ttmserver/SolrTTMServer.php b/ttmserver/SolrTTMServer.php
index 8fe26a5..20b644b 100644
--- a/ttmserver/SolrTTMServer.php
+++ b/ttmserver/SolrTTMServer.php
@@ -17,6 +17,7 @@
class SolrTTMServer extends TTMServer implements ReadableTTMServer,
WritableTTMServer {
protected $client;
protected $updates;
+ protected $revIds;
public function __construct( $config ) {
wfProfileIn( __METHOD__ );
--
To view, visit https://gerrit.wikimedia.org/r/58098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic94b03cd8aafca33ac3d82425dde195fb10c2000
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
