Krinkle has submitted this change and it was merged.
Change subject: Disable Checkstyle reporter of JSHint
......................................................................
Disable Checkstyle reporter of JSHint
The Checkstyle reporter made things worse, not better.
Instead of visualising the data in an easy way it hid the data
behind lots of pages, full of irrelevant data and invalid error
messages.
- Categorised things as "High priority" which is a hack for
Checkstyle that has nothing to do with how JSHint otherwise
outputs it.
- Caused bug 46066.
- Hid data behind a lot of doors:
Job page > Checkstyle repot > High priority > Details
full of "No description available, No description available, .."
No, just give me the plain text reporter without any mess.
Change-Id: I29218fd9786c63eb60617ea66f8637fcd97e9937
---
M macro.yaml
M mediawiki-extensions.yaml
M mediawiki.yaml
3 files changed, 4 insertions(+), 12 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/macro.yaml b/macro.yaml
index 7b8b331..b28fdda 100644
--- a/macro.yaml
+++ b/macro.yaml
@@ -43,17 +43,13 @@
- builder:
name: jshint-in
- # Use `cd` because jshint reads .jshintrc/.jshitignore from PWD
+ # Use `cd` because jshint reads .jshintrc and .jshintignore
+ # from current working directory.
builders:
- shell: |
- #!/bin/bash
+ #!/bin/bash -xe
cd "{dir}"
- /var/lib/jenkins/bin/jshint . --checkstyle-reporter >
"$WORKSPACE/checkstyle-jshint.xml"
- code=$?
- echo
- echo 'Check the "Checkstyle Warnings" link on the left for JSHint
report.'
- echo
- exit $code
+ /var/lib/jenkins/bin/jshint .
- builder:
name: jshint
diff --git a/mediawiki-extensions.yaml b/mediawiki-extensions.yaml
index 5d6bff9..f92c565 100644
--- a/mediawiki-extensions.yaml
+++ b/mediawiki-extensions.yaml
@@ -40,8 +40,6 @@
- zuul
builders:
- jshint
- publishers:
- - checkstyle-xml
- job-template:
name: '{name}-{ext-name}-qunit'
diff --git a/mediawiki.yaml b/mediawiki.yaml
index 15a0d29..3c4ce32 100644
--- a/mediawiki.yaml
+++ b/mediawiki.yaml
@@ -40,8 +40,6 @@
- zuul
builders:
- jshint
- publishers:
- - checkstyle-xml
# Generic job to run QUnit
- job-template:
--
To view, visit https://gerrit.wikimedia.org/r/58330
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29218fd9786c63eb60617ea66f8637fcd97e9937
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
