jenkins-bot has submitted this change and it was merged.
Change subject: Add comments for grep
......................................................................
Add comments for grep
Change-Id: Ib04b072ef8a61326a2ee347aeec585d77f009570
---
M CentralNoticeBannerLogPager.php
M CentralNoticeCampaignLogPager.php
2 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Siebrand: Looks good to me, but someone else must approve
Mwalker: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralNoticeBannerLogPager.php b/CentralNoticeBannerLogPager.php
index b4ed35d..e6d9331 100644
--- a/CentralNoticeBannerLogPager.php
+++ b/CentralNoticeBannerLogPager.php
@@ -196,6 +196,8 @@
$beginField = 'tmplog_begin_'.$param;
$endField = 'tmplog_end_'.$param;
if ( $row->$beginField !== $row->$endField ) {
+ // Give grep a chance to find the usages:
+ // centralnotice-anon, centralnotice-account,
centralnotice-fundraising, centralnotice-autolink
$result .= $this->msg(
'centralnotice-log-label',
$this->msg( 'centralnotice-' . $param )->text(),
@@ -214,6 +216,7 @@
$beginField = 'tmplog_begin_'.$param;
$endField = 'tmplog_end_'.$param;
if ( $row->$beginField !== $row->$endField ) {
+ // Give grep a chance to find the usages:
centralnotice-landingpages, centralnotice-prioritylangs
$result .= $this->msg(
'centralnotice-log-label',
$this->msg( 'centralnotice-'.$param )->text(),
diff --git a/CentralNoticeCampaignLogPager.php
b/CentralNoticeCampaignLogPager.php
index 0d2acec..7ec3de1 100644
--- a/CentralNoticeCampaignLogPager.php
+++ b/CentralNoticeCampaignLogPager.php
@@ -118,6 +118,9 @@
$htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class'
=> 'primary' ),
$this->msg( 'centralnotice-user-links', $userLink,
$userTalkLink )->text()
);
+ // Give grep a chance to find the usages:
+ // centralnotice-action-created, centralnotice-action-modified,
+ // centralnotice-action-removed
$htmlOut .= Xml::tags( 'td', array( 'valign' => 'top', 'class'
=> 'primary' ),
$this->msg( 'centralnotice-action-'.$row->notlog_action
)->text()
);
@@ -305,6 +308,8 @@
$beginField = 'notlog_begin_' . $param;
$endField = 'notlog_end_' . $param;
if ( $row->$beginField !== $row->$endField ) {
+ // Give grep a chance to find the usages:
+ // centralnotice-enabled, centralnotice-locked,
centralnotice-geo, centralnotice-buckets
$result .= $this->msg(
'centralnotice-log-label',
$this->msg( 'centralnotice-'.$param )->text(),
@@ -343,6 +348,8 @@
if ( $removed ) {
$differences .= $this->msg(
'centralnotice-removed', $lang->commaList( $removed ) )->text();
}
+ // Give grep a chance to find the usages:
+ // centralnotice-projects, centralnotice-languages,
centralnotice-countries
$result .= $this->msg(
'centralnotice-log-label',
$this->msg( 'centralnotice-'.$param )->text(),
@@ -391,6 +398,7 @@
$endMessage = $this->msg(
'centralnotice-priority-emergency' )->text();
break;
}
+ // Give grep a chance to find the usages:
centralnotice-preferred
$result .= $this->msg(
'centralnotice-log-label',
$this->msg( 'centralnotice-'.$param )->text(),
--
To view, visit https://gerrit.wikimedia.org/r/58266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib04b072ef8a61326a2ee347aeec585d77f009570
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Shirayuki <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
