jenkins-bot has submitted this change and it was merged.
Change subject: Fixes to Special:PagesWithProp
......................................................................
Fixes to Special:PagesWithProp
- Remove unneeded call to HTMLForm::setAction()
- Call HTMLForm::setWrapperLegendMsg() instead of HTMLForm::setWrapperLegend()
- Use Html::element() instead of Xml::span()
Change-Id: I4bc90c223a89bd31ce2d93a959e9bdf4b546e6dd
---
M includes/specials/SpecialPagesWithProp.php
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Parent5446: Looks good to me, but someone else must approve
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialPagesWithProp.php
b/includes/specials/SpecialPagesWithProp.php
index dc6464a..2f49803 100644
--- a/includes/specials/SpecialPagesWithProp.php
+++ b/includes/specials/SpecialPagesWithProp.php
@@ -70,9 +70,8 @@
),
), $this->getContext() );
$form->setMethod( 'get' );
- $form->setAction( $this->getTitle()->getFullURL() );
$form->setSubmitCallback( array( $this, 'onSubmit' ) );
- $form->setWrapperLegend( $this->msg( 'pageswithprop-legend' ) );
+ $form->setWrapperLegendMsg( 'pageswithprop-legend' );
$form->addHeaderText( $this->msg( 'pageswithprop-text'
)->parseAsBlock() );
$form->setSubmitTextMsg( 'pageswithprop-submit' );
@@ -125,7 +124,7 @@
$ret = Linker::link( $title, null, array(), array(), array(
'known' ) );
if ( $result->pp_value !== '' ) {
$value = $this->msg( 'parentheses' )
- ->rawParams( Xml::span( $result->pp_value,
'prop-value' ) )
+ ->rawParams( Html::element( 'span', array(
'class' => 'prop-value' ), $result->pp_value ) )
->escaped();
$ret .= " $value";
}
--
To view, visit https://gerrit.wikimedia.org/r/57068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4bc90c223a89bd31ce2d93a959e9bdf4b546e6dd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
