Tim Starling has submitted this change and it was merged. Change subject: lint.php: Work-around parsekit bug about conflicts with host file ......................................................................
lint.php: Work-around parsekit bug about conflicts with host file Reported as https://bugs.php.net/64596. Lint.php was unable to lint itself due to this (and potentially any file that declares a global function called "check_dir" or "check_file"). Change-Id: I8159aba3a16b84c4f707c900ddcc158c06260bbc --- M lint.php 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tim Starling: Verified; Looks good to me, approved diff --git a/lint.php b/lint.php index da063f5..3e16a86 100755 --- a/lint.php +++ b/lint.php @@ -34,6 +34,9 @@ static $okErrors = array( 'Redefining already defined constructor', 'Assigning the return value of new by reference is deprecated', + # https://bugs.php.net/64596 + 'Cannot redeclare check_dir() (previously declared in', + 'Cannot redeclare check_file() (previously declared in', ); $errors = array(); parsekit_compile_file( $file, $errors, PARSEKIT_SIMPLE ); -- To view, visit https://gerrit.wikimedia.org/r/57829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8159aba3a16b84c4f707c900ddcc158c06260bbc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/code-utils Gerrit-Branch: master Gerrit-Owner: Krinkle <[email protected]> Gerrit-Reviewer: Demon <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Platonides <[email protected]> Gerrit-Reviewer: Tim Starling <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
