jenkins-bot has submitted this change and it was merged.
Change subject: Better limits on number of notifications in the flyout
......................................................................
Better limits on number of notifications in the flyout
Change-Id: Ic53f6ebe530a73ef89204a96b22194a17d034a12
---
M modules/overlay/ext.echo.overlay.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Bsitu: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/overlay/ext.echo.overlay.js
b/modules/overlay/ext.echo.overlay.js
index 3b7d706..6bc512d 100644
--- a/modules/overlay/ext.echo.overlay.js
+++ b/modules/overlay/ext.echo.overlay.js
@@ -34,10 +34,12 @@
count = 0;
var Api = new mw.Api();
// Set notification limit based on height of the window
- var notificationLimit = Math.floor( ( $( window
).height() - 134 ) / 85 );
+ var notificationLimit = Math.floor( ( $( window
).height() - 134 ) / 90 );
if ( notificationLimit < 1 ) {
notificationLimit = 1;
+ } else if ( notificationLimit > 8 ) {
+ notificationLimit = 8;
}
Api.get( {
--
To view, visit https://gerrit.wikimedia.org/r/58441
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic53f6ebe530a73ef89204a96b22194a17d034a12
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Lwelling <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
