jenkins-bot has submitted this change and it was merged.
Change subject: startup: Lower blacklist for Firefox from 4 to 3.
......................................................................
startup: Lower blacklist for Firefox from 4 to 3.
Though Firefox is 3.6 is both unsupported by Mozilla, by jQuery
and by MediaWiki JS, it is not known to have fatal errors in
javascript run time execution so moving from Grade B (blacklist)
to Grade X (unsupported but given Grade A source code at own risk).
This is done following a thread in English Wikipedia's Village
pump requesting to get the Grade A resources again.
Follows-up 02fe025e6364ebf6f.
Change-Id: Ia54dd738b3ce0995fab6aae7a2729cc7b1a0dcb1
---
M resources/startup.js
M tests/qunit/suites/resources/startup.test.js
2 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
MaxSem: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/startup.js b/resources/startup.js
index 39302bc..e4a16d8 100644
--- a/resources/startup.js
+++ b/resources/startup.js
@@ -26,8 +26,8 @@
return !(
// Internet Explorer < 6
( ua.indexOf( 'MSIE' ) !== -1 && parseFloat( ua.split( 'MSIE'
)[1] ) < 6 ) ||
- // Firefox < 4
- ( ua.indexOf( 'Firefox/' ) !== -1 && parseFloat( ua.split(
'Firefox/' )[1] ) < 4 ) ||
+ // Firefox < 3
+ ( ua.indexOf( 'Firefox/' ) !== -1 && parseFloat( ua.split(
'Firefox/' )[1] ) < 3 ) ||
// BlackBerry < 6
ua.match( /BlackBerry[^\/]*\/[1-5]\./ ) ||
// Open WebOS < 1.5
diff --git a/tests/qunit/suites/resources/startup.test.js
b/tests/qunit/suites/resources/startup.test.js
index 8b33df4..cc8e640 100644
--- a/tests/qunit/suites/resources/startup.test.js
+++ b/tests/qunit/suites/resources/startup.test.js
@@ -48,10 +48,9 @@
'Mozilla/4.0 (compatible; MSIE 4.01; Windows 95)',
'Mozilla/4.0 (compatible; MSIE 5.0; Windows 98;)',
'Mozilla/4.0 (compatible; MSIE 5.5; Windows NT)',
- // Firefox < 4
+ // Firefox < 3.6
'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2',
'Mozilla/5.0 (X11; U; Linux i686; nl; rv:1.8.1.1)
Gecko/20070311 Firefox/2.0.0.1',
- 'Mozilla/5.0 (Windows; U; Windows NT 6.1; ru;
rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3',
// BlackBerry < 6
'BlackBerry9300/5.0.0.716 Profile/MIDP-2.1
Configuration/CLDC-1.1 VendorID/133',
'BlackBerry7250/4.0.0 Profile/MIDP-2.0
Configuration/CLDC-1.1',
@@ -75,6 +74,8 @@
// No explicit support for or against these browsers, they're
// given a shot at Grade A at their own risk.
gradeX: [
+ // Firefox 3.6
+ 'Mozilla/5.0 (Windows; U; Windows NT 6.1; ru;
rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3',
// Gecko
'Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7)
Gecko/20060928 (Debian|Debian-1.8.0.7-1) Epiphany/2.14',
'Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US;
rv:1.8.1.6) Gecko/20070817 IceWeasel/2.0.0.6-g2',
--
To view, visit https://gerrit.wikimedia.org/r/58465
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia54dd738b3ce0995fab6aae7a2729cc7b1a0dcb1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
