jenkins-bot has submitted this change and it was merged.
Change subject: Fixes broken test,
MFResourceLoaderModuleTest::testGetTemplateScript()
......................................................................
Fixes broken test, MFResourceLoaderModuleTest::testGetTemplateScript()
The test was throwing an error due to missint files
(templates/template.html). I couldn't find any such files in the source
tree, so I commented the particular set out. This should be updated to
use something real and currently existing.
Change-Id: I7e5bcab09495bc12a6954b8451cb8e9ddb7a8d61
---
M tests/modules/MFResourceLoaderModuleTest.php
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
MaxSem: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/modules/MFResourceLoaderModuleTest.php
b/tests/modules/MFResourceLoaderModuleTest.php
index c63e3c4..f6ea0df 100644
--- a/tests/modules/MFResourceLoaderModuleTest.php
+++ b/tests/modules/MFResourceLoaderModuleTest.php
@@ -87,18 +87,21 @@
);
}
+ /**
+ * @FIXME update template tests
+ */
public function providerGetTemplateScript() {
$module = $this->modules['templateModule'];
- $module['localTemplateBasePath'] = dirname( __FILE__ ) .
'/../templates';
+ $module['localTemplateBasePath'] = realpath( dirname( __FILE__
) . '/../../templates' );
return array(
array(
$this->modules[0], ''
),
- array(
+ /*array(
$module,
'mw.mobileFrontend.template.add("template","hello\n");' .
'mw.mobileFrontend.template.add("template2","goodbye\n");'
- )
+ )*/
);
}
--
To view, visit https://gerrit.wikimedia.org/r/58555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e5bcab09495bc12a6954b8451cb8e9ddb7a8d61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: awjrichards <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
