Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/58652


Change subject: Surface page images on nearby
......................................................................

Surface page images on nearby

FIXME: This breaks proximity and seems to return an arbitary set
of results

MaxSem is this an issue with the API or am I calling the wrong thing?

Change-Id: I446dbd5d328c6a444e67aa1dd48b257b1169f64d
---
M javascripts/specials/nearby.js
1 file changed, 13 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/52/58652/1

diff --git a/javascripts/specials/nearby.js b/javascripts/specials/nearby.js
index a423f75..0f4262c 100644
--- a/javascripts/specials/nearby.js
+++ b/javascripts/specials/nearby.js
@@ -13,6 +13,9 @@
                pages.sort( function( a, b ) {
                        return a.dist > b.dist ? 1 : -1;
                } ).forEach( function( page ) {
+                       if ( page.thumbnail ) {
+                               page.pageimage = page.thumbnail.source;
+                       }
                        page.url = M.history.getArticleUrl( page.title );
                        page.proximity = mw.message( 
'mobile-frontend-nearby-distance-report',
                                ( page.dist / 1000 ).toFixed( 2 ) );
@@ -31,15 +34,19 @@
                        url: host + M.getApiUrl(),
                        data: {
                                action: 'query',
-                               list: 'geosearch',
+                               prop: 'pageimages',
+                               pithumbsize: 180,
+                               generator: 'geosearch',
                                format: 'json',
-                               gscoord: lat + '|' + lng,
-                               gsradius: range,
-                               gsnamespace: 0,
-                               gslimit: 100
+                               ggscoord: lat + '|' + lng,
+                               ggsradius: range,
+                               ggsnamespace: 0,
+                               ggslimit: 100
                        }
                } ).done( function( data ) {
-                       var pages = data.query.geosearch, $popup;
+                       var pages = $.map( data.query.pages, function( i ) {
+                               return i;
+                       } ), $popup;
                        if ( pages.length > 0 ) {
                                if ( !cachedPages ) {
                                        render( $content, pages );

-- 
To view, visit https://gerrit.wikimedia.org/r/58652
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I446dbd5d328c6a444e67aa1dd48b257b1169f64d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to