jenkins-bot has submitted this change and it was merged.
Change subject: Add all parameters for clarity
......................................................................
Add all parameters for clarity
Update doc, too.
Change-Id: Ife7571e619588976853c094d86944d32ca040019
---
M resources/js/ext.translate.groupselector.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Santhosh: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.groupselector.js
b/resources/js/ext.translate.groupselector.js
index bbde4e7..80729bd 100644
--- a/resources/js/ext.translate.groupselector.js
+++ b/resources/js/ext.translate.groupselector.js
@@ -394,7 +394,7 @@
if ( !groupId ) {
return true;
}
- var childGroups = mw.translate.getGroup( groupId
).groups;
+ var childGroups = mw.translate.getGroup( groupId, null
).groups;
return childGroups && childGroups.length;
},
/**
@@ -574,7 +574,7 @@
* recurse it through sub groups.
*
* @param {string} messageGroupId
- * @param {Array|Object} messageGroups Array of messageGroups
+ * @param {Array|Object} [messageGroups] Array of messageGroups
* @return {Object|boolean} Messagegroup object
*/
mw.translate.getGroup = function ( messageGroupId, messageGroups ) {
--
To view, visit https://gerrit.wikimedia.org/r/58401
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife7571e619588976853c094d86944d32ca040019
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
