jenkins-bot has submitted this change and it was merged. Change subject: RTL tweak for "All notifications" and "Preferences" ......................................................................
RTL tweak for "All notifications" and "Preferences" Some thanks to the following blog post http://snook.ca/archives/html_and_css/background-position-x-y Tested on Chrome and FF latest. Please test on more browsers! Bug: 46215 Change-Id: I0b92b04f3a48dbd85c7e871a75a6973ea9760367 --- R modules/icons/NotificationsPage-ltr.png A modules/icons/NotificationsPage-rtl.png M modules/overlay/ext.echo.overlay.css 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Amire80: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/icons/NotificationsPage.png b/modules/icons/NotificationsPage-ltr.png similarity index 100% rename from modules/icons/NotificationsPage.png rename to modules/icons/NotificationsPage-ltr.png Binary files differ diff --git a/modules/icons/NotificationsPage-rtl.png b/modules/icons/NotificationsPage-rtl.png new file mode 100644 index 0000000..0937002 --- /dev/null +++ b/modules/icons/NotificationsPage-rtl.png Binary files differ diff --git a/modules/overlay/ext.echo.overlay.css b/modules/overlay/ext.echo.overlay.css index 0701ec0..513ccc6 100644 --- a/modules/overlay/ext.echo.overlay.css +++ b/modules/overlay/ext.echo.overlay.css @@ -77,9 +77,9 @@ min-height: 14px; font-size: 13px; /* @embed */ - background-image: url(../icons/NotificationsPage.png); + background-image: url(../icons/NotificationsPage-ltr.png); background-repeat: no-repeat; - background-position: 12px 15px; + background-position: 5% 50%; } #mw-echo-overlay-pref-link { @@ -93,7 +93,7 @@ /* @embed */ background-image: url(../icons/Settings.png); background-repeat: no-repeat; - background-position: 12px 15px; + background-position: 5% 50%; } #pt-notifications { -- To view, visit https://gerrit.wikimedia.org/r/58659 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b92b04f3a48dbd85c7e871a75a6973ea9760367 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Nischayn22 <[email protected]> Gerrit-Reviewer: Amire80 <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Nemo bis <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
