Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/58985
Change subject: Adding Help link to Echo archive page
......................................................................
Adding Help link to Echo archive page
Still needs hover icon from Vibha
Change-Id: Icc9f2c66f983e95c1564f6981e952d1d99160111
---
A modules/special/Help.png
M modules/special/ext.echo.special.css
M modules/special/ext.echo.special.js
M special/SpecialNotifications.php
4 files changed, 37 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/85/58985/1
diff --git a/modules/special/Help.png b/modules/special/Help.png
new file mode 100644
index 0000000..b7020ea
--- /dev/null
+++ b/modules/special/Help.png
Binary files differ
diff --git a/modules/special/ext.echo.special.css
b/modules/special/ext.echo.special.css
index 65b114c..c96ccd5 100644
--- a/modules/special/ext.echo.special.css
+++ b/modules/special/ext.echo.special.css
@@ -14,12 +14,17 @@
max-width: 600px;
}
+.mw-echo-special-header-link {
+ display: block;
+ float: right;
+ font-size: 13px;
+ font-weight: normal;
+ line-height: 14px;
+}
#mw-echo-pref-link {
margin: 5px 3px;
height: 18px;
width: 18px;
- display: block;
- float: right;
/* @embed */
background-image: url(Preferences.png);
background-repeat: no-repeat;
@@ -30,19 +35,27 @@
background-image: url(PreferencesHover.png);
}
#mw-echo-moreinfo-link {
- margin: 5px 3px;
- height: 18px;
- width: 18px;
- display: block;
- float: right;
+ display: inline-block;
+ margin: 0px 3px;
+ height: 16px;
+ width: 16px;
/* @embed */
- background-image: url(MoreInfo.png);
+ background-image: url(Help.png);
background-repeat: no-repeat;
background-position: 0 0;
}
#mw-echo-moreinfo-link:hover {
/* @embed */
- background-image: url(MoreInfoHover.png);
+ background-image: url(HelpHover.png);
+}
+
+#mw-echo-feedback-link {
+ margin: 10px 7px;
+ cursor: pointer;
+}
+#mw-echo-link-separator {
+ color: #AAAAAA;
+ margin: 10px 3px;
}
.mw-echo-date-section {
diff --git a/modules/special/ext.echo.special.js
b/modules/special/ext.echo.special.js
index 67ad0f6..c78b691 100644
--- a/modules/special/ext.echo.special.js
+++ b/modules/special/ext.echo.special.js
@@ -44,13 +44,26 @@
.attr( 'href', mw.config.get( 'wgEchoHelpPage'
) )
.attr( 'title', mw.msg( 'echo-more-info' ) )
.attr( 'id', 'mw-echo-moreinfo-link' )
- .attr( 'class', 'mw-echo-special-header-link' )
.prop( 'target', '_blank' )
.appendTo( $( '#firstHeading' ) );
$( '#mw-echo-pref-link' )
.appendTo( $( '#firstHeading' ) );
+ $( '<div></div>' )
+ .attr( 'id', 'mw-echo-link-separator' )
+ .attr( 'class', 'mw-echo-special-header-link' )
+ .text( '|' )
+ .appendTo( $( '#firstHeading' ) );
+
+ $( '<a/>' )
+ .attr( 'href', mw.config.get(
'wgEchoFeedbackPage' ) )
+ .attr( 'id', 'mw-echo-feedback-link' )
+ .attr( 'class', 'mw-echo-special-header-link' )
+ .prop( 'target', '_blank' )
+ .text( 'Feedback' )
+ .appendTo( $( '#firstHeading' ) );
+
},
/**
diff --git a/special/SpecialNotifications.php b/special/SpecialNotifications.php
index 82d0f93..44e9aa8 100644
--- a/special/SpecialNotifications.php
+++ b/special/SpecialNotifications.php
@@ -39,6 +39,7 @@
$html = Html::rawElement( 'a', array(
'href' => SpecialPage::getTitleFor( 'Preferences'
)->getLinkURL() . '#mw-prefsection-echo',
'id' => 'mw-echo-pref-link',
+ 'class' => 'mw-echo-special-header-link',
'title' => wfMessage( 'preferences' )->text()
) );
--
To view, visit https://gerrit.wikimedia.org/r/58985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc9f2c66f983e95c1564f6981e952d1d99160111
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
