Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/58987


Change subject: (bug 47179) Page Link web or email bundling always show 1 other
......................................................................

(bug 47179) Page Link web or email bundling always show 1 other

This would affect both web and email bundling

Change-Id: If21acb1189ff9de95670bc5519be0700354bb0e7
---
M formatters/PageLinkFormatter.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/87/58987/1

diff --git a/formatters/PageLinkFormatter.php b/formatters/PageLinkFormatter.php
index 3145b23..25c5b46 100644
--- a/formatters/PageLinkFormatter.php
+++ b/formatters/PageLinkFormatter.php
@@ -33,7 +33,11 @@
 
                $count = 1;
                foreach ( $data as $row ) {
-                       $extra = $row->event_extra;
+                       $extra = $row->event_extra ? unserialize( 
$row->event_extra ) : null;
+                       if ( !$extra ) {
+                               continue;
+                       }
+
                        if ( $this->isTitleSet( $extra ) ) {
                                $key = $this->getTitleHash( $extra );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/58987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If21acb1189ff9de95670bc5519be0700354bb0e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to