jenkins-bot has submitted this change and it was merged.
Change subject: Unsquish pageimages on nearby
......................................................................
Unsquish pageimages on nearby
Take into account whether they are portrait or landscape
Change-Id: I45aaaa0ff897febf8d8201fe87f310be88394cd9
---
M javascripts/specials/nearby.js
M templates/articleList.html
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
awjrichards: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/specials/nearby.js b/javascripts/specials/nearby.js
index 7291be3..d0a4c82 100644
--- a/javascripts/specials/nearby.js
+++ b/javascripts/specials/nearby.js
@@ -39,11 +39,13 @@
function render( $content, pages ) {
pages = $.map( pages, function( page ) {
- var coords, lngLat;
+ var coords, lngLat, thumb;
if ( page.coordinates ) { // FIXME: protecting us
against an api bug 47133
if ( page.thumbnail ) {
- page.pageimage = page.thumbnail.source;
+ thumb = page.thumbnail;
+ page.pageimage = thumb.source;
+ page.pageimageClass = thumb.width >
thumb.height ? 'listThumbH' : 'listThumbV';
}
page.url = M.history.getArticleUrl( page.title
);
diff --git a/templates/articleList.html b/templates/articleList.html
index b60ddaf..55eaf05 100644
--- a/templates/articleList.html
+++ b/templates/articleList.html
@@ -2,7 +2,7 @@
{{#pages}}
<li title="{{title}}">
<a href="{{url}}" class="title">
- <div class="listThumb listThumbV"
style="background-image: url({{pageimage}})"></div>
+ <div class="listThumb {{pageimageClass}}"
style="background-image: url({{pageimage}})"></div>
<h2>{{title}}</h2>
<div class="mw-mf-time">{{modified}}</div>
<span class="proximity">{{proximity}}</span>
--
To view, visit https://gerrit.wikimedia.org/r/59002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45aaaa0ff897febf8d8201fe87f310be88394cd9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: awjrichards <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
