jenkins-bot has submitted this change and it was merged.
Change subject: i18n for the thousands marker
......................................................................
i18n for the thousands marker
"k" is understandable as a thousands marker in English and some
other languages, but not in all languages. Converted it into
a message.
This may make the string longer, so the font size of the number
is reduced.
Change-Id: I22d14521bd1f08f25c502652a3776fd009d93c4b
---
M MainPage/MainPage.i18n.php
M MainPage/resources/css/ext.translate.mainpage.css
M MainPage/specials/SpecialTwnMainPage.php
3 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MainPage/MainPage.i18n.php b/MainPage/MainPage.i18n.php
index 31048fe..8b7cc1d 100644
--- a/MainPage/MainPage.i18n.php
+++ b/MainPage/MainPage.i18n.php
@@ -46,6 +46,8 @@
'twnmp-choose-languages-you-know' => 'Choose languages you know',
'twnmp-choose-another-language' => 'Choose another language...',
'twnmp-choose-fill-account-details' => 'Fill in your account details',
+
+ 'twnmp-stats-number-k' => '$1k',
);
/** English
@@ -105,6 +107,11 @@
'twnmp-choose-languages-you-know' => 'A heading to a list of
auto-detected languages.',
'twnmp-choose-another-language' => "A link to choose a language that
doesn't appear in the list.",
'twnmp-choose-fill-account-details' => 'A heading for the personal
details form.',
+
+ 'twnmp-stats-number-k' => '$1 is the number of the thousands of
messages or users on the site.
+It can be a fraction, for example "4.9".
+The message should be short, to fit in the box. If you have to translate it
and cannot make it short, notify [[Support]].
+If "k" is a good thousands marker in your language, do not translate this
message.',
);
/** Hebrew (עברית)
@@ -151,6 +158,8 @@
'twnmp-choose-languages-you-know' => 'השפה שלך',
'twnmp-choose-another-language' => 'בחירת שפה אחרת...',
'twnmp-choose-fill-account-details' => 'הפרטים שלך',
+
+ 'twnmp-stats-number-k' => '$1 אלף',
);
/** Dutch (Nederlands)
diff --git a/MainPage/resources/css/ext.translate.mainpage.css
b/MainPage/resources/css/ext.translate.mainpage.css
index c5aabe1..a6d59f9 100644
--- a/MainPage/resources/css/ext.translate.mainpage.css
+++ b/MainPage/resources/css/ext.translate.mainpage.css
@@ -96,7 +96,7 @@
}
.stats-number {
- font-size: 50px;
+ font-size: 42px;
opacity: 0.9;
}
diff --git a/MainPage/specials/SpecialTwnMainPage.php
b/MainPage/specials/SpecialTwnMainPage.php
index 9ec63d9..84e8f98 100644
--- a/MainPage/specials/SpecialTwnMainPage.php
+++ b/MainPage/specials/SpecialTwnMainPage.php
@@ -336,7 +336,7 @@
if ( $value > 1000 ) {
$digits = 3 - ceil( log( $value, 100 )
);
$value = number_format( $value / 1000,
$digits );
- $value = $lang->formatNum( $value ) .
'k'; // @todo needs proper i18n
+ $value = $this->msg(
'twnmp-stats-number-k' )->numParams( $value )->plain();
} else {
$value = $lang->formatNum( $value );
}
--
To view, visit https://gerrit.wikimedia.org/r/59044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22d14521bd1f08f25c502652a3776fd009d93c4b
Gerrit-PatchSet: 2
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
