Matmarex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59181
Change subject: drop useless HTML comments in Vector
......................................................................
drop useless HTML comments in Vector
They pretty much just repeat the element ids and bloat the code.
Change-Id: I812b1a0456a623db0c32860ab46a332f4d349343
---
M skins/Vector.php
1 file changed, 0 insertions(+), 40 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/81/59181/1
diff --git a/skins/Vector.php b/skins/Vector.php
index 003eed7..1c8c9dc 100644
--- a/skins/Vector.php
+++ b/skins/Vector.php
@@ -155,81 +155,52 @@
?>
<div id="mw-page-base" class="noprint"></div>
<div id="mw-head-base" class="noprint"></div>
- <!-- content -->
<div id="content" class="mw-body" role="main">
<a id="top"></a>
<div id="mw-js-message" style="display:none;"<?php
$this->html( 'userlangattributes' ) ?>></div>
<?php if ( $this->data['sitenotice'] ) { ?>
- <!-- sitenotice -->
<div id="siteNotice"><?php $this->html( 'sitenotice' )
?></div>
- <!-- /sitenotice -->
<?php } ?>
- <!-- firstHeading -->
<h1 id="firstHeading" class="firstHeading" lang="<?php
$this->data['pageLanguage'] =
$this->getSkin()->getTitle()->getPageViewLanguage()->getCode();
$this->html( 'pageLanguage' );
?>"><span dir="auto"><?php $this->html( 'title' )
?></span></h1>
- <!-- /firstHeading -->
- <!-- bodyContent -->
<div id="bodyContent">
<?php if ( $this->data['isarticle'] ) { ?>
- <!-- tagline -->
<div id="siteSub"><?php $this->msg( 'tagline' )
?></div>
- <!-- /tagline -->
<?php } ?>
- <!-- subtitle -->
<div id="contentSub"<?php $this->html(
'userlangattributes' ) ?>><?php $this->html( 'subtitle' ) ?></div>
- <!-- /subtitle -->
<?php if ( $this->data['undelete'] ) { ?>
- <!-- undelete -->
<div id="contentSub2"><?php $this->html(
'undelete' ) ?></div>
- <!-- /undelete -->
<?php } ?>
<?php if ( $this->data['newtalk'] ) { ?>
- <!-- newtalk -->
<div class="usermessage"><?php $this->html(
'newtalk' ) ?></div>
- <!-- /newtalk -->
<?php } ?>
<?php if ( $this->data['showjumplinks'] ) { ?>
- <!-- jumpto -->
<div id="jump-to-nav" class="mw-jump">
<?php $this->msg( 'jumpto' ) ?>
<a href="#mw-navigation"><?php
$this->msg( 'jumptonavigation' ) ?></a><?php $this->msg( 'comma-separator' ) ?>
<a href="#p-search"><?php $this->msg(
'jumptosearch' ) ?></a>
</div>
- <!-- /jumpto -->
<?php } ?>
- <!-- bodycontent -->
<?php $this->html( 'bodycontent' ) ?>
- <!-- /bodycontent -->
<?php if ( $this->data['printfooter'] ) { ?>
- <!-- printfooter -->
<div class="printfooter">
<?php $this->html( 'printfooter' ); ?>
</div>
- <!-- /printfooter -->
<?php } ?>
<?php if ( $this->data['catlinks'] ) { ?>
- <!-- catlinks -->
<?php $this->html( 'catlinks' ); ?>
- <!-- /catlinks -->
<?php } ?>
<?php if ( $this->data['dataAfterContent'] ) {
?>
- <!-- dataAfterContent -->
<?php $this->html( 'dataAfterContent' ); ?>
- <!-- /dataAfterContent -->
<?php } ?>
<div class="visualClear"></div>
- <!-- debughtml -->
<?php $this->html( 'debughtml' ); ?>
- <!-- /debughtml -->
</div>
- <!-- /bodyContent -->
</div>
- <!-- /content -->
<div id="mw-navigation">
<h2><?php $this->msg( 'navigation-heading' ) ?></h2>
- <!-- header -->
<div id="mw-head">
<?php $this->renderNavigation( 'PERSONAL' ); ?>
<div id="left-navigation">
@@ -239,17 +210,11 @@
<?php $this->renderNavigation( array(
'VIEWS', 'ACTIONS', 'SEARCH' ) ); ?>
</div>
</div>
- <!-- /header -->
- <!-- panel -->
<div id="mw-panel">
- <!-- logo -->
<div id="p-logo" role="banner"><a
style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php
echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php
echo Xml::expandAttributes( Linker::tooltipAndAccesskeyAttribs( 'p-logo' ) )
?>></a></div>
- <!-- /logo -->
<?php $this->renderPortals(
$this->data['sidebar'] ); ?>
</div>
- <!-- /panel -->
</div>
- <!-- footer -->
<div id="footer" role="contentinfo"<?php $this->html(
'userlangattributes' ) ?>>
<?php foreach ( $this->getFooterLinks() as $category =>
$links ) { ?>
<ul id="footer-<?php echo $category ?>">
@@ -273,7 +238,6 @@
<?php } ?>
<div style="clear:both"></div>
</div>
- <!-- /footer -->
<?php $this->printTrail(); ?>
</body>
@@ -302,7 +266,6 @@
if ( $content === false )
continue;
- echo "\n<!-- {$name} -->\n";
switch( $name ) {
case 'SEARCH':
break;
@@ -318,7 +281,6 @@
$this->renderPortal( $name, $content );
break;
}
- echo "\n<!-- /{$name} -->\n";
}
}
@@ -379,7 +341,6 @@
}
// Render elements
foreach ( $elements as $name => $element ) {
- echo "\n<!-- {$name} -->\n";
switch ( $element ) {
case 'NAMESPACES':
?>
@@ -488,7 +449,6 @@
break;
}
- echo "\n<!-- /{$name} -->\n";
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/59181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I812b1a0456a623db0c32860ab46a332f4d349343
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
