Subramanya Sastry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/59189


Change subject: Dont use selser for /_rt/* and /_html/* API endpoints.
......................................................................

Dont use selser for /_rt/* and /_html/* API endpoints.

* With this fix, we can have selser enabled always and not affect
  testing with regular WTS.

Change-Id: I183b1a6ed89dfd9087c1de108baac68bff2c44a5
---
M js/api/ParserService.js
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/89/59189/1

diff --git a/js/api/ParserService.js b/js/api/ParserService.js
index d20252e..6b7fc7a 100644
--- a/js/api/ParserService.js
+++ b/js/api/ParserService.js
@@ -266,7 +266,9 @@
                res.end('\n</body></html>');
        };
 
-       new Serializer({env: env}).serializeDOM( document.body,
+       // Always use the regular serializer for round-trip diff tests
+       // since these will never have any edits for selser to do any work.
+       new WikitextSerializer({env: env}).serializeDOM( document.body,
                                function ( chunk ) {
                                        out.push(chunk);
                                }, finalCB );
@@ -393,7 +395,8 @@
                var doc = Util.parseHTML( '<html><body>' + 
req.body.content.replace(/\r/g, '') +
                        '</body></html>' );
                res.write('<pre style="background-color: #efefef">');
-               new Serializer({env: env}).serializeDOM(
+               // Always use the non-selective serializer for this mode
+               new WikitextSerializer({env: env}).serializeDOM(
                        doc.body,
                        function( c ) {
                                res.write( htmlSpecialChars( c ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/59189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I183b1a6ed89dfd9087c1de108baac68bff2c44a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to