Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/59334


Change subject: Show the empty-list helpers
......................................................................

Show the empty-list helpers

Ensure that the different "no messages to show" headings
are shown also when switching modes and not just filters.

Change-Id: Ia7d002aac41997d96f6a55f421f90bdc53296910
---
M resources/js/ext.translate.messagetable.js
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/34/59334/1

diff --git a/resources/js/ext.translate.messagetable.js 
b/resources/js/ext.translate.messagetable.js
index 7294c49..ee1d0dc 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -57,6 +57,7 @@
                // mode can be proofread, page or translate
                this.mode = this.options.mode;
                this.firstProofreadTipShown = false;
+               this.initialized = false;
                this.$loader = this.$container.siblings( 
'.tux-messagetable-loader' );
                this.$actionBar = this.$container.siblings( '.tux-action-bar' );
                this.messages = [];
@@ -68,6 +69,7 @@
        MessageTable.prototype = {
                init: function () {
                        this.switchMode( this.mode );
+                       this.initialized = true;
                },
 
                listen: function () {
@@ -656,9 +658,13 @@
                                }
                        }
 
-                       $.each( messageTable.messages, function ( index, 
message ) {
-                               messageTable.add( message );
-                       } );
+                       if ( messageTable.messages.length ) {
+                               $.each( messageTable.messages, function ( 
index, message ) {
+                                       messageTable.add( message );
+                               } );
+                       } else if ( messageTable.initialized ) {
+                               messageTable.displayEmptyListHelp();
+                       }
                },
 
                /**

-- 
To view, visit https://gerrit.wikimedia.org/r/59334
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7d002aac41997d96f6a55f421f90bdc53296910
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to