Inez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59348
Change subject: Inside ve.ce.Document.getRelativeOffset fallback to 'character'
mode if 'word' mode returns the same offset as was passed originally
......................................................................
Inside ve.ce.Document.getRelativeOffset fallback to 'character' mode if 'word'
mode returns the same offset as was passed originally
Change-Id: Ia3de5d5c1f37f17161fb1c8c9a284c868bb4a5fb
---
M modules/ve/ce/ve.ce.Document.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/48/59348/1
diff --git a/modules/ve/ce/ve.ce.Document.js b/modules/ve/ce/ve.ce.Document.js
index 120571a..73a2879 100644
--- a/modules/ve/ce/ve.ce.Document.js
+++ b/modules/ve/ce/ve.ce.Document.js
@@ -84,9 +84,13 @@
* @returns {number} Relative offset
*/
ve.ce.Document.prototype.getRelativeOffset = function ( offset, direction,
unit ) {
- var bias, relativeContentOffset, relativeStructuralOffset;
+ var bias, relativeContentOffset, relativeStructuralOffset, newOffset;
if ( unit === 'word' ) { // word
- return this.getSiblingWordBoundary( offset, direction );
+ newOffset = this.getSiblingWordBoundary( offset, direction );
+ if ( offset === newOffset ) {
+ newOffset = this.getRelativeOffset( offset, direction,
'character' );
+ }
+ return newOffset;
} else { // character
bias = direction > 0 ? 1 : -1;
relativeContentOffset =
this.model.data.getRelativeContentOffset( offset, direction );
--
To view, visit https://gerrit.wikimedia.org/r/59348
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3de5d5c1f37f17161fb1c8c9a284c868bb4a5fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
