jenkins-bot has submitted this change and it was merged.

Change subject: Remove the code the tries to create an invalid notification
......................................................................


Remove the code the tries to create an invalid notification

Although invalid notification would be checked and not be created, it's better 
to get rid of any attempt of creating invalid notifications

Change-Id: I4bdbf7e0706b3613c7cf31ab07570fb4d1cdd045
---
M Hooks.php
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Kaldari: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Hooks.php b/Hooks.php
index a953f63..399ed73 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -397,13 +397,6 @@
        public static function onArticleSaved( &$article, &$user, $text, 
$summary, $minoredit, $watchthis, $sectionanchor, &$flags, $revision, &$status 
) {
                global $wgEchoNotifications, $wgRequest;
                if ( $revision ) {
-                       EchoEvent::create( array(
-                               'type' => 'edit',
-                               'title' => $article->getTitle(),
-                               'extra' => array( 'revid' => $revision->getID() 
),
-                               'agent' => $user,
-                       ) );
-
                        if ( $article->getTitle()->isTalkPage() ) {
                                
EchoDiscussionParser::generateEventsForRevision( $revision );
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/59195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4bdbf7e0706b3613c7cf31ab07570fb4d1cdd045
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to