MaxSem has submitted this change and it was merged.
Change subject: Address nearby FIXME using colimit
......................................................................
Address nearby FIXME using colimit
just removing if statement and adding colimit parameter
Change-Id: Iadf9db7d6cbf40e5703ebed45f7cabc1487724a6
---
M javascripts/specials/nearby.js
1 file changed, 15 insertions(+), 16 deletions(-)
Approvals:
MaxSem: Verified; Looks good to me, approved
diff --git a/javascripts/specials/nearby.js b/javascripts/specials/nearby.js
index d579516..9478347 100644
--- a/javascripts/specials/nearby.js
+++ b/javascripts/specials/nearby.js
@@ -66,23 +66,21 @@
pages = $.map( pages, function( page ) {
var coords, lngLat, thumb;
- if ( page.coordinates ) { // FIXME: protecting us
against an api bug 47133
- if ( page.thumbnail ) {
- thumb = page.thumbnail;
- page.listThumbStyleAttribute =
'background-image: url(' + thumb.source + ')';
- page.pageimageClass = thumb.width >
thumb.height ? 'listThumbH' : 'listThumbV';
- } else {
- page.pageimageClass = 'needsPhoto';
- }
- page.url = M.history.getArticleUrl( page.title
);
-
- coords = page.coordinates[0],
- lngLat = { latitude: coords.lat, longitude:
coords.lon };
- page.dist = calculateDistance( curLocation,
lngLat );
- page.proximity = distanceMessage( page.dist );
- pages.push( page );
- return page;
+ if ( page.thumbnail ) {
+ thumb = page.thumbnail;
+ page.listThumbStyleAttribute =
'background-image: url(' + thumb.source + ')';
+ page.pageimageClass = thumb.width >
thumb.height ? 'listThumbH' : 'listThumbV';
+ } else {
+ page.pageimageClass = 'needsPhoto';
}
+ page.url = M.history.getArticleUrl( page.title );
+
+ coords = page.coordinates[0],
+ lngLat = { latitude: coords.lat, longitude: coords.lon
};
+ page.dist = calculateDistance( curLocation, lngLat );
+ page.proximity = distanceMessage( page.dist );
+ pages.push( page );
+ return page;
} );
pages.sort( function( a, b ) {
return a.dist > b.dist ? 1 : -1;
@@ -103,6 +101,7 @@
url: endpoint || M.getApiUrl(),
data: {
action: 'query',
+ colimit: 'max',
prop: 'pageimages|coordinates',
pithumbsize: 180,
pilimit: limit,
--
To view, visit https://gerrit.wikimedia.org/r/59171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadf9db7d6cbf40e5703ebed45f7cabc1487724a6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
