jenkins-bot has submitted this change and it was merged.
Change subject: Fix annotation breakage
......................................................................
Fix annotation breakage
Inez reported that unitalicizing from the toolbar was broken, because
the toolbar was somehow generating annotations that had .attributes={}
as opposed to .attributes=undefined. Turned out the cause was in the
default value for element in the ve.dm.Model constructor.
Change-Id: I64ea9ef56cd15d1131c1aa23484d7420c95a8225
---
M modules/ve/dm/ve.dm.Model.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Inez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/dm/ve.dm.Model.js b/modules/ve/dm/ve.dm.Model.js
index cb06357..550fc83 100644
--- a/modules/ve/dm/ve.dm.Model.js
+++ b/modules/ve/dm/ve.dm.Model.js
@@ -14,7 +14,7 @@
*/
ve.dm.Model = function VeDmModel( element ) {
// Properties
- this.element = element || { 'type': this.constructor.static.name,
'attributes': {} };
+ this.element = element || { 'type': this.constructor.static.name };
};
ve.dm.Model.static = {};
--
To view, visit https://gerrit.wikimedia.org/r/59363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64ea9ef56cd15d1131c1aa23484d7420c95a8225
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Inez <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
