Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59532
Change subject: Funnel fail
......................................................................
Funnel fail
The funnel for nearby/watchlist is only being flagged on the photo
upload form on the uploads page.
I changed the wrong file. Doh.
Change-Id: I105a0c5935bfae33a3e462903b88359fbca33d3e
---
M javascripts/modules/mf-photo.js
M javascripts/specials/uploads.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/32/59532/1
diff --git a/javascripts/modules/mf-photo.js b/javascripts/modules/mf-photo.js
index 7e8aec3..eb401e8 100644
--- a/javascripts/modules/mf-photo.js
+++ b/javascripts/modules/mf-photo.js
@@ -531,7 +531,7 @@
buttonCaption: mw.msg( 'mobile-frontend-photo-upload' ),
insertInPage: true,
pageTitle: mw.config.get( 'wgTitle' ),
- funnel: 'article'
+ funnel: $.cookie( 'mwUploadsFunnel' ) || 'article'
} ).
insertAfter( $pageHeading ).
on( 'start', function() {
diff --git a/javascripts/specials/uploads.js b/javascripts/specials/uploads.js
index 9264708..4bc6f72 100644
--- a/javascripts/specials/uploads.js
+++ b/javascripts/specials/uploads.js
@@ -166,7 +166,7 @@
new photo.PhotoUploader( {
buttonCaption: mw.msg(
'mobile-frontend-photo-upload-generic' ),
pageTitle: mw.config.get( 'wgTitle' ),
- funnel: $.cookie( 'mwUploadsFunnel' ) ||
'uploads'
+ funnel: 'uploads'
} ).
appendTo( $container ).
on( 'success', function( image ) {
--
To view, visit https://gerrit.wikimedia.org/r/59532
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I105a0c5935bfae33a3e462903b88359fbca33d3e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
