J has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/59602


Change subject: Revert temporary plain text output from I75e37906
......................................................................

Revert temporary plain text output from I75e37906

Bug 44525 that required this change is fixed now,
reverting back to working version.

Bug: 43747
Change-Id: Ie142dc57359121866b603e65d0f7941cf1539d22
---
M resources/mw.MediaWikiPlayerSupport.js
1 file changed, 2 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/02/59602/1

diff --git a/resources/mw.MediaWikiPlayerSupport.js 
b/resources/mw.MediaWikiPlayerSupport.js
index 2b0febd..3b41139 100644
--- a/resources/mw.MediaWikiPlayerSupport.js
+++ b/resources/mw.MediaWikiPlayerSupport.js
@@ -117,10 +117,6 @@
                        // Add the title:
                        $creditLine.append(
                                $('<span>').html(
-                                       // Changed to use only text due to 
change Ifbeae7e9
-                                       // Change back once bug 44525 is fixed
-                                       mw.msg( 'mwe-embedplayer-credit-title' 
, titleStr )
-                                       /*
                                        mw.msg( 'mwe-embedplayer-credit-title' ,
                                                // get the link
                                                $('<div>').append(
@@ -131,7 +127,6 @@
                                                        .text( titleStr )
                                                )[0].innerHTML
                                        )
-                                       */
                                )
                        );
 
@@ -156,9 +151,7 @@
                                        )
                                }
                                $creditLine.append( $( '<br />' ),
-                                       // Switched from .html() to .text() due 
to change Ifbeae7e9
-                                       // Change back once bug 44525 is fixed
-                                       mw.msg('mwe-embedplayer-credit-author', 
$authorText.text() )
+                                       mw.msg('mwe-embedplayer-credit-author', 
$authorText.html() )
                                )
                        }
 
@@ -171,9 +164,7 @@
                                // remove white space:
                                $date.find('br').remove();
                                $creditLine.append(  $( '<br />' ),
-                                       // Switched from .html() to .text() due 
to change Ifbeae7e9
-                                       // Change back once bug 44525 is fixed
-                                       mw.msg('mwe-embedplayer-credit-date', 
$date.text() )
+                                       mw.msg('mwe-embedplayer-credit-date', 
$date.html() )
                                )
                        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/59602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie142dc57359121866b603e65d0f7941cf1539d22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: J <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to