Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59647
Change subject: Add protection for bug
......................................................................
Add protection for bug
Currently the nearby page will 'explode' (not render) on this bug.
This wraps the offender so that the page is still rendered and it is obvious
which page has been effected by the bug
Change-Id: I392a837af485f2528800c665088c8ae8e6f25f81
---
M javascripts/specials/nearby.js
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/47/59647/1
diff --git a/javascripts/specials/nearby.js b/javascripts/specials/nearby.js
index 168c66a..a4df064 100644
--- a/javascripts/specials/nearby.js
+++ b/javascripts/specials/nearby.js
@@ -74,11 +74,12 @@
page.pageimageClass = 'needsPhoto';
}
page.url = M.history.getArticleUrl( page.title );
-
- coords = page.coordinates[0],
- lngLat = { latitude: coords.lat, longitude: coords.lon
};
- page.dist = calculateDistance( curLocation, lngLat );
- page.proximity = distanceMessage( page.dist );
+ if ( page.coordinates ) { // protect against bug 47133
+ coords = page.coordinates[0],
+ lngLat = { latitude: coords.lat, longitude:
coords.lon };
+ page.dist = calculateDistance( curLocation,
lngLat );
+ page.proximity = distanceMessage( page.dist );
+ }
pages.push( page );
return page;
} );
--
To view, visit https://gerrit.wikimedia.org/r/59647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I392a837af485f2528800c665088c8ae8e6f25f81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits