Demon has submitted this change and it was merged.

Change subject: Changed scope for junit from test to compile so mvn package 
actually works
......................................................................


Changed scope for junit from test to compile so mvn package actually works

Real fix is of course to make mwdumper comply with the maven folder structure.
The problem was caused by the fact that test and regular source code files
are in the same folder.
Also added some files to .gitignore

Change-Id: Id984bf84fd8888bafefec894d976f4e6dd00f561
---
M .gitignore
M pom.xml
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Demon: Verified; Looks good to me, approved



diff --git a/.gitignore b/.gitignore
index f61aa0d..d926e62 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,5 @@
 .settings
 .project
 target/
+.idea/
+mwdumper.iml
diff --git a/pom.xml b/pom.xml
index 66bd5bc..513fc7e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,7 +53,7 @@
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
       <version>3.8</version>
-      <scope>test</scope>
+      <scope>compile</scope>
     </dependency>
   </dependencies>
 

-- 
To view, visit https://gerrit.wikimedia.org/r/59093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id984bf84fd8888bafefec894d976f4e6dd00f561
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/mwdumper
Gerrit-Branch: master
Gerrit-Owner: Diederik <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to