Yaron Koren has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59849
Change subject: Removed check of $wgEmailConfirmToEdit - causes problems with
newer MW versions
......................................................................
Removed check of $wgEmailConfirmToEdit - causes problems with newer MW versions
Change-Id: I33011d5f9949bb6fbf89e4bde9e5b9554f7b00c1
---
M ApprovedRevs.hooks.php
1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ApprovedRevs
refs/changes/49/59849/1
diff --git a/ApprovedRevs.hooks.php b/ApprovedRevs.hooks.php
index fabbffd..89df2eb 100644
--- a/ApprovedRevs.hooks.php
+++ b/ApprovedRevs.hooks.php
@@ -259,11 +259,7 @@
return true;
}
- // For some reason, the userCan() check always returns false
- // when $wgEmailConfirmToEdit is set - is that a bug in
- // MediaWiki? In any case, don't escape here if it's set.
- global $wgEmailConfirmToEdit;
- if ( ! $title->userCan( 'viewlinktolatest' ) &&
!$wgEmailConfirmToEdit ) {
+ if ( ! $title->userCan( 'viewlinktolatest' ) ) {
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/59849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33011d5f9949bb6fbf89e4bde9e5b9554f7b00c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApprovedRevs
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
