Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59860
Change subject: Call $project->editArticle for all member changes.
......................................................................
Call $project->editArticle for all member changes.
Previously we called this from the GUI when a
member was explicitly added or removed; this
missed the case where memebers were added
to bastion thanks to a change in shell rights.
So, now the call to editArticle() is in the actual
add/delete member functions inside the project class
so we should catch every single one.
Change-Id: Id9fc29747a0838f6c208cdc197a0273723e92ee3
---
M nova/OpenStackNovaProject.php
M special/SpecialNovaProject.php
2 files changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager
refs/changes/60/59860/1
diff --git a/nova/OpenStackNovaProject.php b/nova/OpenStackNovaProject.php
index 2e64e98..d31c2d0 100644
--- a/nova/OpenStackNovaProject.php
+++ b/nova/OpenStackNovaProject.php
@@ -421,6 +421,7 @@
}
$this->fetchProjectInfo(true);
$wgAuth->printDebug( "Successfully removed
$user->userDN from $this->projectDN", NONSENSITIVE );
+ $this->editArticle();
return true;
} else {
$wgAuth->printDebug( "Failed to remove
$user->userDN from $this->projectDN: " . ldap_error($wgAuth->ldapconn),
NONSENSITIVE );
@@ -504,6 +505,7 @@
$this->fetchProjectInfo( true );
$wgAuth->printDebug( "Successfully added $user->userDN
to $this->projectDN", NONSENSITIVE );
+ $this->editArticle();
return true;
} else {
$wgAuth->printDebug( "Failed to add $user->userDN to
$this->projectDN: " . ldap_error($wgAuth->ldapconn), NONSENSITIVE );
diff --git a/special/SpecialNovaProject.php b/special/SpecialNovaProject.php
index 2543284..16ae11a 100644
--- a/special/SpecialNovaProject.php
+++ b/special/SpecialNovaProject.php
@@ -654,7 +654,6 @@
}
$success = $project->addMember( $member );
if ( $success ) {
- $project->editArticle();
$this->getOutput()->addWikiMsg(
'openstackmanager-addedto', $formData['member'], $formData['projectname'] );
} else {
$this->getOutput()->addWikiMsg(
'openstackmanager-failedtoadd', $formData['member'], $formData['projectname'] );
@@ -685,7 +684,6 @@
foreach ( $formData['members'] as $member ) {
$success = $project->deleteMember( $member );
if ( $success ) {
- $project->editArticle();
$this->getOutput()->addWikiMsg(
'openstackmanager-removedfrom', $member, $formData['projectname'] );
} else {
$this->getOutput()->addWikiMsg(
'openstackmanager-failedtoremove', $member, $formData['projectname'] );
--
To view, visit https://gerrit.wikimedia.org/r/59860
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9fc29747a0838f6c208cdc197a0273723e92ee3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
