Rfaulk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/59867
Change subject: mod. except clause too broad - pass on empty queue only.
......................................................................
mod. except clause too broad - pass on empty queue only.
Change-Id: Ibcd1ee38fbae1b9a23dbd28445f2ae21f83fb95d
---
M user_metrics/api/engine/request_manager.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/E3Analysis
refs/changes/67/59867/1
diff --git a/user_metrics/api/engine/request_manager.py
b/user_metrics/api/engine/request_manager.py
index 205c661..b48434d 100644
--- a/user_metrics/api/engine/request_manager.py
+++ b/user_metrics/api/engine/request_manager.py
@@ -655,7 +655,7 @@
lock.acquire()
try:
req_notification_queue_in.put([0, key, url])
- except:
+ except Empty:
pass
finally:
lock.release()
@@ -665,7 +665,7 @@
lock.acquire()
try:
req_notification_queue_in.put([1, key], True)
- except:
+ except Empty:
pass
finally:
lock.release()
--
To view, visit https://gerrit.wikimedia.org/r/59867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcd1ee38fbae1b9a23dbd28445f2ae21f83fb95d
Gerrit-PatchSet: 1
Gerrit-Project: analytics/E3Analysis
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
