JGonera has submitted this change and it was merged. Change subject: Bug 44959: Allow overlay heading title to span 2 lines ......................................................................
Bug 44959: Allow overlay heading title to span 2 lines As raised in bug 44959, In some languages it is not 1 line. This fixes up the header so that the padding belongs to the header itself meaning the title will never overlap the 'hamburger' left menu button e.g. Special:Mobileoptions See https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mobile-frontend-main-menu-settings-heading/en Change-Id: I27c719e85ba3e1c29891b2bf74d971bb433c2f5c --- M less/common/ui.less M stylesheets/common/ui.css 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: JGonera: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/less/common/ui.less b/less/common/ui.less index 6dad40e..927c460 100644 --- a/less/common/ui.less +++ b/less/common/ui.less @@ -16,7 +16,6 @@ border-bottom: 1px solid #e2e2e2; line-height: @headerHeight; text-align: center; - padding: 0; min-height: @headerHeight; margin: 0; overflow: hidden; @@ -26,6 +25,11 @@ line-height: @headerHeight; margin: 0; } +} + +.mw-mf-overlay .header .search-box, +#mw-mf-header { + padding: 0 @searchBarPaddingRight 0 @searchBarPaddingLeft; } /* Menu buttons */ @@ -94,7 +98,6 @@ } .search-box { - padding: 0 @searchBarPaddingRight 0 @searchBarPaddingLeft; -webkit-tap-highlight-color: rgba(255, 255, 255, 0); } diff --git a/stylesheets/common/ui.css b/stylesheets/common/ui.css index 05a8f43..fce9f1f 100644 --- a/stylesheets/common/ui.css +++ b/stylesheets/common/ui.css @@ -236,7 +236,6 @@ border-bottom: 1px solid #e2e2e2; line-height: 46px; text-align: center; - padding: 0; min-height: 46px; margin: 0; overflow: hidden; @@ -246,6 +245,10 @@ color: #000000; line-height: 46px; margin: 0; +} +.mw-mf-overlay .header .search-box, +#mw-mf-header { + padding: 0 40px 0 40px; } /* Menu buttons */ #mw-mf-menu-page, @@ -315,7 +318,6 @@ display: none; } .search-box { - padding: 0 40px 0 40px; -webkit-tap-highlight-color: rgba(255, 255, 255, 0); } /* samsung galaxy s gt-19000 */ -- To view, visit https://gerrit.wikimedia.org/r/58725 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27c719e85ba3e1c29891b2bf74d971bb433c2f5c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: JGonera <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
