Prageck has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60035
Change subject: Fixed Bug 40464 Placeholder attribute of searchInput element
......................................................................
Fixed Bug 40464 Placeholder attribute of searchInput element
The placeholder attribute of #searchInput element is now set in the original
HTML rather than after the page is finished loading which earlier resulted
in an unpleasant "blink" of placeholder.
Bug: 40464
Change-Id: I6496716f2bd25307004ba16bceadca4c6723a5db
---
M includes/SkinTemplate.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/35/60035/1
diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index 17ec88a..a5709ea 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -1804,6 +1804,7 @@
$realAttrs = array(
'type' => 'search',
'name' => 'search',
+ 'placeholder' => wfMessage( 'searchsuggest-search'
)->text(),
'value' => isset( $this->data['search'] ) ?
$this->data['search'] : '',
);
$realAttrs = array_merge( $realAttrs,
Linker::tooltipAndAccesskeyAttribs( 'search' ), $attrs );
--
To view, visit https://gerrit.wikimedia.org/r/60035
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6496716f2bd25307004ba16bceadca4c6723a5db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prageck <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
