Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60226
Change subject: Break up our 'sudo' commands into separate args.
......................................................................
Break up our 'sudo' commands into separate args.
This makes 'sudo' happier.
Change-Id: Iaead542d633eda99d94d43facb02a25fc857d549
---
M files/ldap/scripts/manage-nfs-volumes-daemon
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/26/60226/1
diff --git a/files/ldap/scripts/manage-nfs-volumes-daemon
b/files/ldap/scripts/manage-nfs-volumes-daemon
index 9bf4b8a..e75b136 100755
--- a/files/ldap/scripts/manage-nfs-volumes-daemon
+++ b/files/ldap/scripts/manage-nfs-volumes-daemon
@@ -234,8 +234,8 @@
# We need to clean up from partially-failed runs. rmdir is pretty
conservative; it will
# only clean up empty dirs.
- cmds1 = ['sudo', 'rmdir %s' % voldir]
- cmds2 = ['sudo', 'mkdir -p %s' % voldir]
+ cmds1 = ['sudo', 'rmdir', voldir]
+ cmds2 = ['sudo', 'mkdir', '-p', voldir]
if self.dry_run:
print "Exec %s" % cmds1
--
To view, visit https://gerrit.wikimedia.org/r/60226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaead542d633eda99d94d43facb02a25fc857d549
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
