Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 47435) Fix problem with dismissing copyright notice ......................................................................
(bug 47435) Fix problem with dismissing copyright notice Improvement of I010f7086fec45814c2715667f2d2056fdfd926b0 which lead to the copyright notice not to be shown anymore. Instead of using a simple clone, we now clone data and events as well. Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45 --- M lib/resources/wikibase.ui.Tooltip.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/lib/resources/wikibase.ui.Tooltip.js b/lib/resources/wikibase.ui.Tooltip.js index 7a52903..0c20700 100644 --- a/lib/resources/wikibase.ui.Tooltip.js +++ b/lib/resources/wikibase.ui.Tooltip.js @@ -236,7 +236,7 @@ // The DOM content needs to be cloned since IE8 will lose the reference to the DOM // content when the inner HTML is removed within tipsy's native show() method. if ( this._DomContent ) { - this._DomContent = this._DomContent.clone(); + this._DomContent = this._DomContent.clone( true ); } this._tipsy.show(); -- To view, visit https://gerrit.wikimedia.org/r/60277 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d2517568b394f9da8e2ad753e5c8d9fe9595a45 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits